linux-kernel - Re: [PATCH v1 2/3] ipmi: bt-i2c: added IPMI Block Transfer over I2C host side

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 6 Aug 2017 05:37:25 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Brendan Higgins <brendanhiggins@...gle.com>
Cc:     kbuild-all@...org, corbet@....net, robh+dt@...nel.org,
        mark.rutland@....com, arnd@...db.de, gregkh@...uxfoundation.org,
        minyard@....org, joel@....id.au, benh@...nel.crashing.org,
        linux-doc@...r.kernel.org, devicetree@...r.kernel.org,
        openipmi-developer@...ts.sourceforge.net, openbmc@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org,
        Brendan Higgins <brendanhiggins@...gle.com>
Subject: Re: [PATCH v1 2/3] ipmi: bt-i2c: added IPMI Block Transfer over I2C
 host side

Hi Brendan,

[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on v4.13-rc3 next-20170804]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Brendan-Higgins/ipmi-bt-i2c-added-IPMI-Block-Transfer-over-I2C/20170806-033950
config: ia64-allyesconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 6.2.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

   drivers/char/ipmi/ipmi_bt_i2c.c: In function 'ipmi_bt_i2c_receive_response':
>> drivers/char/ipmi/ipmi_bt_i2c.c:119:7: error: implicit declaration of function 'signal_pending' [-Werror=implicit-function-declaration]
      if (signal_pending(current))
          ^~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/signal_pending +119 drivers/char/ipmi/ipmi_bt_i2c.c

    97	
    98	static int ipmi_bt_i2c_receive_response(struct ipmi_bt_i2c_master *master,
    99						struct ipmi_bt_i2c_msg *response)
   100	{
   101		struct i2c_client *client = master->client;
   102		unsigned long timeout, read_time;
   103		u8 *buf = (u8 *) response;
   104		u8 len = 0;
   105		int ret;
   106	
   107		/*
   108		 * Slave may not NACK when not ready, so we peek at the first byte to
   109		 * see if it is a valid length.
   110		 */
   111		ret = i2c_master_recv(client, &len, 1);
   112		while (ret != 1 || len == 0) {
   113			if (ret < 0)
   114				return ret;
   115	
   116			usleep_range(1000, 1500);
   117	
   118			/* Signal received: quit syscall. */
 > 119			if (signal_pending(current))
   120				return -ERESTARTSYS;
   121	
   122			ret = i2c_master_recv(client, &len, 1);
   123		}
   124	
   125		timeout = jiffies + msecs_to_jiffies(write_timeout);
   126		do {
   127			read_time = jiffies;
   128			ret = i2c_master_recv(client, buf, len + 1);
   129			if (ret >= 0)
   130				return 0;
   131			usleep_range(1000, 1500);
   132		} while (time_before(read_time, timeout));
   133		return ret;
   134	}
   135	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (51472 bytes)