linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: do not change the valid_block value if cur_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <421ee9e7-89af-d414-9b12-7bc47dc7bc69@kernel.org>
Date:   Sat, 5 Aug 2017 09:23:48 +0800
From:   Chao Yu <chao@...nel.org>
To:     Yunlong Song <yunlong.song@...wei.com>, jaegeuk@...nel.org,
        yuchao0@...wei.com, yunlong.song@...oud.com
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: do not change the valid_block value if
 cur_valid_map was wrongly set or cleared

On 2017/8/2 22:16, Yunlong Song wrote:
> Signed-off-by: Yunlong Song <yunlong.song@...wei.com>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

> ---
>  fs/f2fs/segment.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 40e40c5..9e3249a 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1540,6 +1540,8 @@ static void update_sit_entry(struct f2fs_sb_info *sbi, block_t blkaddr, int del)
>  			f2fs_msg(sbi->sb, KERN_ERR,
>  				"Bitmap was wrongly set, blk:%u", blkaddr);
>  			f2fs_bug_on(sbi, 1);
> +			se->valid_blocks--;
> +			del = 0;
>  		}
>  
>  		if (f2fs_discard_en(sbi) &&
> @@ -1567,6 +1569,8 @@ static void update_sit_entry(struct f2fs_sb_info *sbi, block_t blkaddr, int del)
>  			f2fs_msg(sbi->sb, KERN_ERR,
>  				"Bitmap was wrongly cleared, blk:%u", blkaddr);
>  			f2fs_bug_on(sbi, 1);
> +			se->valid_blocks++;
> +			del = 0;
>  		}
>  
>  		if (f2fs_discard_en(sbi) &&
>