linux-kernel - Re: [PATCH 18/18] i2c-cht-wc: Add device-properties for fusb302 integration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ba933c6-daae-f30d-2c83-e9c2b756d27f@roeck-us.net>
Date:   Sun, 6 Aug 2017 07:35:15 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Hans de Goede <hdegoede@...hat.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        Sebastian Reichel <sre@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-i2c@...r.kernel.org, Liam Breck <liam@...workimprov.net>,
        Tony Lindgren <tony@...mide.com>, linux-pm@...r.kernel.org,
        devel@...verdev.osuosl.org
Subject: Re: [PATCH 18/18] i2c-cht-wc: Add device-properties for fusb302
 integration

On 08/06/2017 05:35 AM, Hans de Goede wrote:
> Add device-properties to make the bq24292i controller connected to
> the bus get its input-current-limit from the fusb302 Type-C port
> controller which is used on boards with the cht-wc PMIC.
> 
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> ---
>   drivers/i2c/busses/Kconfig      | 5 +++++
>   drivers/i2c/busses/i2c-cht-wc.c | 5 ++++-
>   2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index f20b1f84013a..6de21a81b00b 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -197,6 +197,11 @@ config I2C_CHT_WC
>   	  SMBus controller found in the Intel Cherry Trail Whiskey Cove PMIC
>   	  found on some Intel Cherry Trail systems.
>   
> +	  Note this controller is hooked up to a TI bq24292i charger-IC,
> +	  combined with a FUSB302 Type-C port-controller as such it is advised
> +	  to also select CONFIG_CHARGER_BQ24190=m and CONFIG_TYPEC_FUSB302=m
> +	  (the fusb302 driver currently is in drivers/staging).
> +

Just wondering - is this always the case ? What if someone builds a system with
different charger and port controller ICs ?

>   config I2C_NFORCE2
>   	tristate "Nvidia nForce2, nForce3 and nForce4"
>   	depends on PCI
> diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
> index ccf0785bcb75..08229fb12615 100644
> --- a/drivers/i2c/busses/i2c-cht-wc.c
> +++ b/drivers/i2c/busses/i2c-cht-wc.c
> @@ -211,8 +211,11 @@ static const struct irq_chip cht_wc_i2c_irq_chip = {
>   	.name			= "cht_wc_ext_chrg_irq_chip",
>   };
>   
> +static const char * const bq24190_suppliers[] = { "fusb302-typec-source" };
> +
>   static const struct property_entry bq24190_props[] = {
> -	PROPERTY_ENTRY_STRING("extcon-name", "cht_wcove_pwrsrc"),
> +	PROPERTY_ENTRY_STRING_ARRAY("supplied-from", bq24190_suppliers),
> +	PROPERTY_ENTRY_BOOL("input-current-limit-from-supplier"),
>   	PROPERTY_ENTRY_BOOL("omit-battery-class"),
>   	PROPERTY_ENTRY_BOOL("disable-reset"),
>   	{ }
>