linux-kernel - Re: [PATCH] ALSA: ice1712: add const to snd_ak4xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h60e030z5.wl-tiwai@suse.de>
Date:   Sun, 06 Aug 2017 22:17:18 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Bhumika Goyal" <bhumirks@...il.com>
Cc:     <alsa-devel@...a-project.org>, <julia.lawall@...6.fr>,
        <perex@...ex.cz>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: ice1712: add const to snd_ak4xxx_private structures

On Fri, 04 Aug 2017 17:34:41 +0200,
Bhumika Goyal wrote:
> 
> Declare snd_ak4xxx_private structures  as const as they are only passed
> to the function snd_ice1712_akm4xxx_init. This argument is of type const,
> so make the structures const.
> Done using Coccinelle:
> 
> @match disable optional_qualifier@
> identifier s;
> position p;
> @@
> static struct snd_ak4xxx_private s@......};
> 
> @good1@
> identifier match.s;
> position p;
> @@
> snd_ice1712_akm4xxx_init(...,&s@p,...)
> 
> @bad@
> identifier match.s;
> position p!={match.p,good1.p};
> @@
> s@p
> 
> @depends on !bad disable optional_qualifier@
> identifier match.s;
> @@
> static
> +const
> struct snd_ak4xxx_private s={...};
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Applied, thanks.


Takashi