linux-kernel - Re: [PATCH 21/29] scsi: nsp32: constify pci_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 7 Aug 2017 10:37:03 +0900
From:   Masanori Goto <gotom@...ian.or.jp>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     martin.petersen@...cle.com, jejb@...ux.vnet.ibm.com,
        Michael Reed <mdr@....com>, hare@...e.com, aacraid@...ptec.com,
        Matthew Wilcox <matthew@....cx>, fthain@...egraphics.com.au,
        schmitzmic@...il.com, kashyap.desai@...adcom.com,
        sumit.saxena@...adcom.com, mrochs@...ux.vnet.ibm.com,
        QLogic-Storage-Upstream@...ium.com, jinpu.wang@...fitbricks.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 21/29] scsi: nsp32: constify pci_device_id.

2017-07-30 17:43 GMT+09:00 Arvind Yadav <arvind.yadav.cs@...il.com>:
>
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Thank you!  (resending it twice due to an error)

Acked-by: Masanori Goto <gotom@...ian.or.jp>


> ---
>  drivers/scsi/nsp32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c
> index 53c8477..1430b3c 100644
> --- a/drivers/scsi/nsp32.c
> +++ b/drivers/scsi/nsp32.c
> @@ -76,7 +76,7 @@ static const char *nsp32_release_version = "1.2";
>  /****************************************************************************
>   * Supported hardware
>   */
> -static struct pci_device_id nsp32_pci_table[] = {
> +static const struct pci_device_id nsp32_pci_table[] = {
>         {
>                 .vendor      = PCI_VENDOR_ID_IODATA,
>                 .device      = PCI_DEVICE_ID_NINJASCSI_32BI_CBSC_II,
> --
> 2.7.4