linux-kernel - Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core (fwd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 7 Aug 2017 07:59:20 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     dwmw2@...radead.org
cc:     vndao@...era.com, dwmw2@...radead.org, computersforpeace@...il.com,
        boris.brezillon@...e-electrons.com, marek.vasut@...il.com,
        richard@....at, cyrille.pitchen@...ev4u.fr, robh+dt@...nel.org,
        mark.rutland@....com, linux-mtd@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        gregkh@...uxfoundation.org, davem@...emloft.net,
        mchehab@...nel.org, linux-fpga@...r.kernel.org, kbuild-all@...org
Subject: Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core
 (fwd)

dev_err does not seem possible to use here (line 447).

julia

---------- Forwarded message ----------
Date: Mon, 7 Aug 2017 04:45:58 +0800
From: kbuild test robot <fengguang.wu@...el.com>
To: kbuild@...org
Cc: Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH 2/2] mtd: spi-nor: Altera ASMI Parallel II IP Core

Hi Matthew,

[auto build test WARNING on next-20170804]
[also build test WARNING on v4.13-rc3]
[cannot apply to mtd/spi-nor/fixes linus/master mtd/master v4.13-rc3 v4.13-rc2 v4.13-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/matthew-gerlach-linux-intel-com/dt-bindings-mtd-Altera-ASMI-Parallel-II-IP-Core/20170807-023147
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago

>> drivers/mtd/spi-nor/altera-asmip2.c:447:17-20: ERROR: pdev is NULL but dereferenced.

# https://github.com/0day-ci/linux/commit/ec2e26c1b07806d734a2939530e7d4b4d7c67f0c
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout ec2e26c1b07806d734a2939530e7d4b4d7c67f0c
vim +447 drivers/mtd/spi-nor/altera-asmip2.c

ec2e26c1 Matthew Gerlach 2017-08-06  443
ec2e26c1 Matthew Gerlach 2017-08-06  444  static int altera_asmip2_remove(struct platform_device *pdev)
ec2e26c1 Matthew Gerlach 2017-08-06  445  {
ec2e26c1 Matthew Gerlach 2017-08-06  446  	if (!pdev) {
ec2e26c1 Matthew Gerlach 2017-08-06 @447  		dev_err(&pdev->dev, "%s NULL\n", __func__);
ec2e26c1 Matthew Gerlach 2017-08-06  448  		return -EINVAL;
ec2e26c1 Matthew Gerlach 2017-08-06  449  	} else {
ec2e26c1 Matthew Gerlach 2017-08-06  450  		return altera_asmip2_remove_banks(&pdev->dev);
ec2e26c1 Matthew Gerlach 2017-08-06  451  	}
ec2e26c1 Matthew Gerlach 2017-08-06  452  }
ec2e26c1 Matthew Gerlach 2017-08-06  453

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation