linux-kernel - Re: [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h8xjq2rw.fsf@concordia.ellerman.id.au>
Date:   Mon, 07 Aug 2017 17:02:11 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Zhao Qiang <qiang.zhao@....com>, tglx@...utronix.de
Cc:     oss@...error.net, Zhao Qiang <qiang.zhao@....com>,
        linuxppc-dev@...ts.ozlabs.org, xiaobo.xie@....com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 4/4] irqchip/qeic: remove PPCisms for QEIC

Zhao Qiang <qiang.zhao@....com> writes:

> QEIC was supported on PowerPC, and dependent on PPC,
> Now it is supported on other platforms, so remove PPCisms.
>
> Signed-off-by: Zhao Qiang <qiang.zhao@....com>
> ---
>  arch/powerpc/platforms/83xx/km83xx.c          |   1 -
>  arch/powerpc/platforms/83xx/misc.c            |   1 -
>  arch/powerpc/platforms/83xx/mpc832x_mds.c     |   1 -
>  arch/powerpc/platforms/83xx/mpc832x_rdb.c     |   1 -
>  arch/powerpc/platforms/83xx/mpc836x_mds.c     |   1 -
>  arch/powerpc/platforms/83xx/mpc836x_rdk.c     |   1 -
>  arch/powerpc/platforms/85xx/corenet_generic.c |   1 -
>  arch/powerpc/platforms/85xx/mpc85xx_mds.c     |   1 -
>  arch/powerpc/platforms/85xx/mpc85xx_rdb.c     |   1 -
>  arch/powerpc/platforms/85xx/twr_p102x.c       |   1 -
>  drivers/irqchip/irq-qeic.c                    | 188 +++++++++++---------------
>  include/soc/fsl/qe/qe_ic.h                    | 132 ------------------
>  12 files changed, 80 insertions(+), 250 deletions(-)
>  delete mode 100644 include/soc/fsl/qe/qe_ic.h
>
> diff --git a/arch/powerpc/platforms/83xx/km83xx.c b/arch/powerpc/platforms/83xx/km83xx.c
> index d8642a4..b1cef0a 100644
> --- a/arch/powerpc/platforms/83xx/km83xx.c
> +++ b/arch/powerpc/platforms/83xx/km83xx.c
> @@ -38,7 +38,6 @@
>  #include <sysdev/fsl_soc.h>
>  #include <sysdev/fsl_pci.h>
>  #include <soc/fsl/qe/qe.h>
> -#include <soc/fsl/qe/qe_ic.h>

You deleted that file in patch 2. So didn't you just break the build for
the last two commits?

cheers