linux-kernel - Re: [PATCH] Fix missing PCI ID (thanks to CoolStar); Necessary for Lenovo Yoga 720-15 Touchpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 7 Aug 2017 08:57:16 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Hoeze <git.ich@...oelzlwimmer.de>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix missing PCI ID (thanks to CoolStar); Necessary for
 Lenovo Yoga 720-15 Touchpad

Subject line looks wrong.  To see the format expected please use:

 `git log --oneline -- drivers/mfd`

You are missing your SoB.

> ---
> This patch fixes a missing PCI ID which is necessary for the Lenovo Yoga 720-15 Touchpad to work.

This should be in the commit log above.

> See this bug report on Launchpad:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1700657

Drop external links to LP please.

> Many thanks to CoolStar, who found this solution!

This should be a "Reported-by".

Please see Documentation/SubmittingPatches' for more details.

>  drivers/mfd/intel-lpss-pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index 16ffeaeb1385..867df181d475 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -208,6 +208,7 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
>  	{ PCI_VDEVICE(INTEL, 0xa12a), (kernel_ulong_t)&spt_info },
>  	{ PCI_VDEVICE(INTEL, 0xa160), (kernel_ulong_t)&spt_i2c_info },
>  	{ PCI_VDEVICE(INTEL, 0xa161), (kernel_ulong_t)&spt_i2c_info },
> +    { PCI_VDEVICE(INTEL, 0xa162), (kernel_ulong_t)&spt_i2c_info },

The tabbing looks wrong here.

>  	{ PCI_VDEVICE(INTEL, 0xa166), (kernel_ulong_t)&spt_uart_info },
>  	/* KBL-H */
>  	{ PCI_VDEVICE(INTEL, 0xa2a7), (kernel_ulong_t)&spt_uart_info },

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog