linux-kernel - [PATCH 3/5] block-skd: Delete an unnecessary return statement in skd_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Aug 2017 15:02:09 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Arnd Bergmann <arnd@...db.de>,
        Geliang Tang <geliangtang@...il.com>,
        Jens Axboe <axboe@...nel.dk>, kernel-janitors@...r.kernel.org
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH 3/5] block-skd: Delete an unnecessary return statement in
 skd_pci_remove()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Mon, 7 Aug 2017 14:10:35 +0200

The script "checkpatch.pl" pointed information out like the following.

WARNING: void function return statements are not generally useful

Thus remove such a statement in the affected function.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/block/skd_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index fa8569d4543b..8e2c89069927 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -4831,8 +4831,6 @@ static void skd_pci_remove(struct pci_dev *pdev)
 	pci_release_regions(pdev);
 	pci_disable_device(pdev);
 	pci_set_drvdata(pdev, NULL);
-
-	return;
 }
 
 static int skd_pci_suspend(struct pci_dev *pdev, pm_message_t state)
-- 
2.13.4