linux-kernel - Re: [PATCH] loop: fix to a race condition due to the early registration of device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e99d4f73-5d73-8141-558f-c918245abc42@ispras.ru>
Date:   Mon, 7 Aug 2017 16:09:12 +0300
From:   Anton Volkov <avolkov@...ras.ru>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     tom.leiming@...il.com, axboe@...com, osandov@...com,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        ldv-project@...uxtesting.org, khoroshilov@...ras.ru
Subject: Re: [PATCH] loop: fix to a race condition due to the early
 registration of device

This is more of a style-oriented suggestion. This kind of template is 
commonly used in other modules.

Regards,
Anton

On 07.08.2017 15:54, Johannes Thumshirn wrote:
> On Mon, Aug 07, 2017 at 03:37:50PM +0300, Anton Volkov wrote:
>> +err_out:
>>   	return err;
> 
> Any reason you can't just use return err; at the respective callsites?
> 
> Thanks,
> 	Johannes
> 

-- Anton Volkov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: avolkov@...ras.ru