linux-kernel - Re: [PATCH] arm64: correct modules range of kernel virtual memory layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170807131608.GA18817@arm.com>
Date:   Mon, 7 Aug 2017 14:16:09 +0100
From:   Will Deacon <will.deacon@....com>
To:     Miles Chen <miles.chen@...iatek.com>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, wsd_upstream@...iatek.com,
        ard.biesheuvel@...aro.org
Subject: Re: [PATCH] arm64: correct modules range of kernel virtual memory
 layout

On Mon, Aug 07, 2017 at 07:04:46PM +0800, Miles Chen wrote:
> The commit f80fb3a3d508 ("arm64: add support for kernel ASLR")
> moved module virtual address to
> [module_alloc_base, module_alloc_base + MODULES_VSIZE).
> 
> Display module information of the virtual kernel
> memory layout by using module_alloc_base.
> 
> testing output:
> 1) Current implementation:
> Virtual kernel memory layout:
> 	modules : 0xffffff8000000000 - 0xffffff8008000000   (   128 MB)
> 2) this patch + KASLR:
> Virtual kernel memory layout:
> 	modules : 0xffffff8000560000 - 0xffffff8008560000   (   128 MB)
> 3) this patch + KASLR and a dummy seed:
> Virtual kernel memory layout:
> 	modules : 0xffffffa7df637000 - 0xffffffa7e7637000   (   128 MB)
> 
> Signed-off-by: Miles Chen <miles.chen@...iatek.com>
> ---
>  arch/arm64/mm/init.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Does this mean the modules code in our pt dumper is busted
(arch/arm64/mm/dump.c)? Also, what about KASAN, which uses these addresses
too (in kasan_init)? Should we just remove MODULES_VADDR and MODULES_END
altogether?

Will