linux-kernel - Re: [PATCH v2 7/7] edac drivers: add MC owner check in init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1502117279.2042.130.camel@hpe.com>
Date:   Mon, 7 Aug 2017 14:57:35 +0000
From:   "Kani, Toshimitsu" <toshi.kani@....com>
To:     "bp@...en8.de" <bp@...en8.de>
CC:     "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>
Subject: Re: [PATCH v2 7/7] edac drivers: add MC owner check in init

On Sat, 2017-08-05 at 07:49 +0200, Borislav Petkov wrote:
> On Fri, Aug 04, 2017 at 09:48:23PM +0000, Kani, Toshimitsu wrote:
> > Not sure if anyone cares, but I thought it should return with
> > -ENODEV when this modules found no target, and -EBUSY when it found
> > a target but it's busy.  Hence, this ordering.
> 
> You can still return -EBUSY. Just do the owner check first because if
> we're going to return due to ghes_edac being loaded already, we might
> just as well skip the other checks as they're a pointless waste of
> cycles and energy.

Got it.  Will move up the check.

Thanks,
-Toshi