linux-kernel - Re: [PATCH] ASoC: compress: Remove duplicated code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170807150714.e7aecqskfelp7h5z@sirena.org.uk>
Date:   Mon, 7 Aug 2017 16:07:14 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Donglin Peng <dolinux.peng@...il.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: compress: Remove duplicated code

On Mon, Aug 07, 2017 at 09:18:09PM +0800, Donglin Peng wrote:

> The value of the variable new_name is assigned repeatedly.

> @@ -737,9 +737,6 @@ int snd_soc_new_compress(struct snd_soc_pcm_runtime
> *rtd, int num)
>         }
> 
>         /* check client and interface hw capabilities */
> -       snprintf(new_name, sizeof(new_name), "%s %s-%d",
> -                       rtd->dai_link->stream_name, codec_dai->name, num);
> -

Are you sure that this is the assignment that should be deleted, and if
so why?  Note that it's both conditionally and unconditionally assigned
later on...  Some words in the commit log about why this copy is removed
would be helpful.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)