[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b6b5f2f0-bbfe-8471-d8fc-e236ea0b1ea4@infradead.org>
Date: Mon, 7 Aug 2017 08:10:59 -0700
From: Geoff Levand <geoff@...radead.org>
To: SF Markus Elfring <elfring@...rs.sourceforge.net>,
linuxppc-dev@...ts.ozlabs.org,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Michael Ellerman <mpe@...erman.id.au>,
Paul Mackerras <paulus@...ba.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] block/ps3vram: Delete an error message for a failed
memory allocation in ps3vram_cache_init()
On 08/07/2017 03:52 AM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 7 Aug 2017 12:37:01 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
NACK
When a user asks me for help I would certainly like to get
'Could not allocate cache tags' as apposed to nothing, since
the return value of ps3vram_cache_init() is not checked.
If you want to make an improvement please add a check for
success of ps3vram_cache_init() in ps3vram_probe().
-Geoff
Powered by blists - more mailing lists