linux-kernel - [PATCH] block-sx8: Delete an error message for a failed memory allocation in carm_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <e28e8cff-107d-4aca-cce2-43001f95e445@users.sourceforge.net>
Date:   Mon, 7 Aug 2017 17:25:35 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Jens Axboe <axboe@...com>, kernel-janitors@...r.kernel.org
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] block-sx8: Delete an error message for a failed memory
 allocation in carm_init_one()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Mon, 7 Aug 2017 17:14:21 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/block/sx8.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/block/sx8.c b/drivers/block/sx8.c
index 08586dc14e85..4b1800f6724d 100644
--- a/drivers/block/sx8.c
+++ b/drivers/block/sx8.c
@@ -1605,8 +1605,6 @@ static int carm_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	host = kzalloc(sizeof(*host), GFP_KERNEL);
 	if (!host) {
-		printk(KERN_ERR DRV_NAME "(%s): memory alloc failure\n",
-		       pci_name(pdev));
 		rc = -ENOMEM;
 		goto err_out_regions;
 	}
-- 
2.13.4