linux-kernel - Re: [PATCH v2] hysdn: fix to a race condition in put_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170807.112543.687820539253956584.davem@davemloft.net>
Date:   Mon, 07 Aug 2017 11:25:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     avolkov@...ras.ru
Cc:     isdn@...ux-pingi.de, sergei.shtylyov@...entembedded.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        ldv-project@...uxtesting.org, khoroshilov@...ras.ru
Subject: Re: [PATCH v2] hysdn: fix to a race condition in put_log_buffer

From: Anton Volkov <avolkov@...ras.ru>
Date: Mon,  7 Aug 2017 15:54:14 +0300

> The synchronization type that was used earlier to guard the loop that
> deletes unused log buffers may lead to a situation that prevents any
> thread from going through the loop.
> 
> The patch deletes previously used synchronization mechanism and moves
> the loop under the spin_lock so the similar cases won't be feasible in
> the future.
> 
> Found by by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Anton Volkov <avolkov@...ras.ru>
> ---
> v2: Fixed coding style issues

Applied.