linux-kernel - Re: [PATCH] tpm/tpm_crb: Access locality for only CRB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2017 16:36:43 -0600
From:   Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:     Jiandi An <anjiandi@...eaurora.org>
Cc:     tpmdd-devel@...ts.sourceforge.net, peterhuewe@....de,
        tpmdd@...horst.net, jarkko.sakkinen@...ux.intel.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm/tpm_crb: Access locality for only CRB_START method

On Sun, Aug 06, 2017 at 09:54:15PM -0500, Jiandi An wrote:

>  static int __maybe_unused crb_go_idle(struct device *dev, struct crb_priv *priv)
>  {
> -	if ((priv->flags & CRB_FL_ACPI_START) ||
> -	    (priv->flags & CRB_FL_CRB_SMC_START))
> +	if (!(priv->flags & CRB_FL_CRB_START))

I think it would be better to have these list the cases where go_idle
is known to be required. Less brittle that way..

  if ((priv->flags & (CRB_FL_ACPI_START | CRB_FL_CRB_START)) == 0)
       return 0

> -	if (!(priv->flags & CRB_FL_ACPI_START)) {
> +	if (priv->flags & CRB_FL_CRB_START) {

Eg like this now makes more sense, assumming CRB_START is the right
test :)

Jason