linux-kernel - Re: [PATCH v06 09/36] uapi asm-generic/sembuf.h: include asm/posix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Aug 2017 01:45:55 +0300
From:   "Dmitry V. Levin" <ldv@...linux.org>
To:     Mikko Rapeli <mikko.rapeli@....fi>
Cc:     linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
        "H . J . Lu" <hjl.tools@...il.com>,
        "H . Peter Anvin" <hpa@...or.com>, Arnd Bergmann <arnd@...db.de>,
        linux-arch@...r.kernel.org
Subject: Re: [PATCH v06 09/36] uapi asm-generic/sembuf.h: include
 asm/posix_types.h and asm/ipcbuf.h

On Sun, Aug 06, 2017 at 06:44:00PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation errors like:
> 
> error: field ‘msg_perm’ has incomplete type
> struct ipc64_perm msg_perm;
> error: unknown type name ‘__kernel_ulong_t’
> 
> Signed-off-by: Mikko Rapeli <mikko.rapeli@....fi>
> Acked-by: Arnd Bergmann <arnd@...db.de>
> Cc: H.J. Lu <hjl.tools@...il.com>
> Cc: H. Peter Anvin <hpa@...or.com>
> ---
>  include/uapi/asm-generic/sembuf.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/uapi/asm-generic/sembuf.h b/include/uapi/asm-generic/sembuf.h
> index 4cb2c13e5090..17d523f86923 100644
> --- a/include/uapi/asm-generic/sembuf.h
> +++ b/include/uapi/asm-generic/sembuf.h
> @@ -2,6 +2,8 @@
>  #define __ASM_GENERIC_SEMBUF_H
>  
>  #include <asm/bitsperlong.h>
> +#include <asm/posix_types.h>
> +#include <asm/ipcbuf.h>

I don't think you need to include <asm/posix_types.h> here,
<asm/ipcbuf.h> is necessary and enough, see
http://lkml.kernel.org/r/20170302002228.GB27132@altlinux.org


-- 
ldv

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)