linux-kernel - Re: [PATCH v06 21/36] uapi linux/kexec.h: use __kernel_size_t instead of size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Aug 2017 02:15:43 +0300
From:   "Dmitry V. Levin" <ldv@...linux.org>
To:     Mikko Rapeli <mikko.rapeli@....fi>
Cc:     linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
        kexec@...ts.infradead.org, Eric Biederman <ebiederm@...ssion.com>
Subject: Re: [PATCH v06 21/36] uapi linux/kexec.h: use __kernel_size_t
 instead of size_t

On Sun, Aug 06, 2017 at 06:44:12PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation error:
> 
> error: unknown type name ‘size_t’
>   size_t bufsz;
> 
> Signed-off-by: Mikko Rapeli <mikko.rapeli@....fi>
> Cc: kexec@...ts.infradead.org
> Cc: Eric Biederman <ebiederm@...ssion.com>
> ---
>  include/uapi/linux/kexec.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/uapi/linux/kexec.h b/include/uapi/linux/kexec.h
> index aae5ebf2022b..f964d83b2757 100644
> --- a/include/uapi/linux/kexec.h
> +++ b/include/uapi/linux/kexec.h
> @@ -51,9 +51,9 @@
>   */
>  struct kexec_segment {
>  	const void *buf;
> -	size_t bufsz;
> +	__kernel_size_t bufsz;
>  	const void *mem;
> -	size_t memsz;
> +	__kernel_size_t memsz;

No, this is definitely wrong as it breaks x32.
I submitted an alternative fix some time ago, see
http://lkml.kernel.org/r/20170222224646.GC14311@altlinux.org


-- 
ldv

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)