linux-kernel - RE: [PATCH] devfreq: add error check for sscanf in userspace governor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170808001443epcms1p53655025662e843eab56aca33554b09df@epcms1p5>
Date:   Tue, 08 Aug 2017 00:14:43 +0000
From:   MyungJoo Ham <myungjoo.ham@...sung.com>
To:     Kyungmin Park <kyungmin.park@...sung.com>,
        "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
        Chanwoo Choi <cw00.choi@...sung.com>
CC:     "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "gsantosh@....qualcomm.com" <gsantosh@....qualcomm.com>,
        "gsantosh@...eaurora.org" <gsantosh@...eaurora.org>,
        "skannan@...cinc.com" <skannan@...cinc.com>,
        "rgottimu@....qualcomm.com" <rgottimu@....qualcomm.com>
Subject: RE: [PATCH] devfreq: add error check for sscanf in userspace
 governor

> store_freq function of devfreq userspace governor
> executes further, even if error is returned from sscanf,
> this will result in setting up wrong frequency value.
> 
> Add proper error check to bail out if any error is returned.
> 
> Signed-off-by: Santosh Mardi <gsantosh@...eaurora.org>

Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>

> ---
>  drivers/devfreq/governor_userspace.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)