linux-kernel - Re: [PATCH v2 4/4] KVM: arm: implements the kvm_arch_vcpu_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2017 09:41:46 +0200
From:   Christoffer Dall <christoffer.dall@...aro.org>
To:     "Longpeng(Mike)" <longpeng2@...wei.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Alexander Graf <agraf@...e.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        cohuck@...hat.com, Christoffer Dall <christoffer.dall@...aro.org>,
        "marc.zyngier@....com" <marc.zyngier@....com>,
        James Hogan <james.hogan@...tec.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        weidong.huang@...wei.com, arei.gonglei@...wei.com,
        wangxinxin.wang@...wei.com, longpeng.mike@...il.com,
        David Hildenbrand <david@...hat.com>
Subject: Re: [PATCH v2 4/4] KVM: arm: implements the kvm_arch_vcpu_in_kernel()

On Tue, Aug 8, 2017 at 9:39 AM, Christoffer Dall <cdall@...aro.org> wrote:
> On Tue, Aug 08, 2017 at 12:05:35PM +0800, Longpeng(Mike) wrote:
>> This implements the kvm_arch_vcpu_in_kernel() for ARM.
>>
>> Signed-off-by: Longpeng(Mike) <longpeng2@...wei.com>
>> ---
>>  virt/kvm/arm/arm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
>> index 862f820..b9f68e4 100644
>> --- a/virt/kvm/arm/arm.c
>> +++ b/virt/kvm/arm/arm.c
>> @@ -418,7 +418,7 @@ int kvm_arch_vcpu_runnable(struct kvm_vcpu *v)
>>
>>  bool kvm_arch_vcpu_in_kernel(struct kvm_vcpu *vcpu)
>>  {
>> -     return false;
>> +     return vcpu_mode_priv(vcpu);
>>  }
>>
>>  /* Just ensure a guest exit from a particular CPU */
>> --
>> 1.8.3.1
>>
>>
> I'm not taking any position on whether this series makes sense overall
> or not (it's a bit concerning to do this without having measured a
> benefit), but for the arm/arm64 change:

oh, sorry, strike that, I didn't notice you had added performance
results in the cover letter.

Thanks,
-Christoffer

>
> Acked-by: Christoffer Dall <cdall@...aro.org>