[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 8 Aug 2017 11:00:33 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Liam Breck <liam@...workimprov.net>
Cc: Darren Hart <dvhart@...radead.org>,
Andy Shevchenko <andy@...radead.org>,
Wolfram Sang <wsa@...-dreams.de>,
Sebastian Reichel <sre@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Guenter Roeck <linux@...ck-us.net>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
platform-driver-x86@...r.kernel.org,
linux-kernel <linux-kernel@...r.kernel.org>,
linux-i2c@...r.kernel.org, Tony Lindgren <tony@...mide.com>,
linux-pm@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH 13/18] power: supply: bq24190_charger: Export 5V boost
converter as regulator
Hi,
On 08-08-17 10:39, Liam Breck wrote:
> Hi Hans,
>
> On Sun, Aug 6, 2017 at 5:35 AM, Hans de Goede <hdegoede@...hat.com> wrote:
>> Register the 5V boost converter as a regulator named
>> "regulator-bq24190-usb-vbus". Note the name includes "bq24190" because
>> the bq24190 family is also used on ACPI devices where there are no
>> device-tree phandles, so regulator_get will fallback to the name and thus
>> it must be unique on the system.
>
> What we're enabling here is 5V boost for otg host mode, not vbus
> generally, so maybe the name should indicate that...
>
> regulator-bq24190-usb-5volt
> regulator-bq24190-usb-host
> regulator-bq24190-usb-otg-5v
I picked vbus because that gets used a lot already in similar cases,
but I agree that we should probably come up with a better name.
I like "regulator-bq24190-usb-otg-5v", shall I use that for v2?
Regards,
Hans
Powered by blists - more mailing lists