linux-kernel - Re: [PATCH] thermal: fix INTEL_SOC_DTS_IOSF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 08 Aug 2017 17:15:08 +0800
From:   Zhang Rui <rui.zhang@...el.com>
To:     "Pandruvada, Srinivas" <srinivas.pandruvada@...el.com>,
        "edubezval@...il.com" <edubezval@...il.com>,
        "arnd@...db.de" <arnd@...db.de>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies

On Sat, 2017-07-29 at 13:22 -0600, Pandruvada, Srinivas wrote:
> On Fri, 2017-07-21 at 18:16 +0200, Arnd Bergmann wrote:
> > 
> > We get a Kconfig warning when selecting this without also enabling
> > CONFIG_PCI:
> > 
> > warning: (X86_INTEL_LPSS && INTEL_SOC_DTS_IOSF_CORE &&
> > SND_SST_IPC_ACPI && MMC_SDHCI_ACPI && PUNIT_ATOM_DEBUG) selects
> > IOSF_MBI which has unmet direct dependencies (PCI)
> > 
> > This adds a new depedency.
> > 
> > Fixes: 3a2419f865a6 ("Thermal: Intel SoC: DTS thermal use common
> > APIs")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com

Applied.

thanks,
rui
> >
> 
> > 
> > ---
> >  drivers/thermal/Kconfig | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > index b5b5facb8747..ac2a53823576 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -342,7 +342,7 @@ config X86_PKG_TEMP_THERMAL
> >  
> >  config INTEL_SOC_DTS_IOSF_CORE
> >  	tristate
> > -	depends on X86
> > +	depends on X86 && PCI
> >  	select IOSF_MBI
> >  	help
> >  	  This is becoming a common feature for Intel SoCs to
> > expose
> > the additional
> > @@ -352,7 +352,7 @@ config INTEL_SOC_DTS_IOSF_CORE
> >  
> >  config INTEL_SOC_DTS_THERMAL
> >  	tristate "Intel SoCs DTS thermal driver"
> > -	depends on X86
> > +	depends on X86 && PCI
> >  	select INTEL_SOC_DTS_IOSF_CORE
> >  	select THERMAL_WRITABLE_TRIPS
> >  	help