[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 8 Aug 2017 12:15:56 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Chen Zhong <chen.zhong@...iatek.com>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Matthias Brugger <matthias.bgg@...il.com>,
Eddie Huang <eddie.huang@...iatek.com>,
Alessandro Zummo <a.zummo@...ertech.it>,
Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
Jaechul Lee <jcsing.lee@...sung.com>,
Jonathan Cameron <jic23@...nel.org>,
Javier Martinez Canillas <javier@....samsung.com>,
Linus Walleij <linus.walleij@...aro.org>,
Beomho Seo <beomho.seo@...sung.com>,
linux-input@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-rtc@...r.kernel.org
Subject: Re: [PATCH v2 5/5] mfd: mt6397: Add PMIC keys support to MT6397
driver
On Mon, 07 Aug 2017, Chen Zhong wrote:
> This patch adds compatible strings and interrupts for pmic keys
> which serves as child device of MFD.
>
> Signed-off-by: Chen Zhong <chen.zhong@...iatek.com>
> ---
> drivers/mfd/mt6397-core.c | 36 +++++++++++++++++++++++++++++++++++-
> 1 file changed, 35 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 6546d7f..3c6a765 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -43,6 +43,30 @@
> },
> };
>
> +static const struct resource mt6323_keys_resources[] = {
> + {
> + .start = MT6323_IRQ_STATUS_PWRKEY,
> + .end = MT6323_IRQ_STATUS_PWRKEY,
> + .flags = IORESOURCE_IRQ,
> + }, {
> + .start = MT6323_IRQ_STATUS_FCHRKEY,
> + .end = MT6323_IRQ_STATUS_FCHRKEY,
> + .flags = IORESOURCE_IRQ,
> + },
> +};
> +
> +static const struct resource mt6397_keys_resources[] = {
> + {
> + .start = MT6397_IRQ_PWRKEY,
> + .end = MT6397_IRQ_PWRKEY,
> + .flags = IORESOURCE_IRQ,
> + }, {
> + .start = MT6397_IRQ_HOMEKEY,
> + .end = MT6397_IRQ_HOMEKEY,
> + .flags = IORESOURCE_IRQ,
> + },
> +};
We have better ways to define these now.
Please grep for "DEFINE_RES_"
> static const struct mfd_cell mt6323_devs[] = {
> {
> .name = "mt6323-regulator",
> @@ -50,6 +74,11 @@
> }, {
> .name = "mt6323-led",
> .of_compatible = "mediatek,mt6323-led"
> + }, {
> + .name = "mtk-pmic-keys",
> + .num_resources = ARRAY_SIZE(mt6323_keys_resources),
> + .resources = mt6323_keys_resources,
> + .of_compatible = "mediatek,mt6323-keys"
> },
> };
>
> @@ -71,7 +100,12 @@
> }, {
> .name = "mt6397-pinctrl",
> .of_compatible = "mediatek,mt6397-pinctrl",
> - },
> + }, {
> + .name = "mtk-pmic-keys",
> + .num_resources = ARRAY_SIZE(mt6397_keys_resources),
> + .resources = mt6397_keys_resources,
> + .of_compatible = "mediatek,mt6397-keys"
> + }
> };
>
> static void mt6397_irq_lock(struct irq_data *data)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists