linux-kernel - Re: [PATCH] omap/hsmmc: constify dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2017 13:34:10 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Doug Wilson <doug.lkml@...il.com>
Cc:     linux-omap <linux-omap@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Doug Wilson <doug.wilson@...il.com>
Subject: Re: [PATCH] omap/hsmmc: constify dev_pm_ops

On 8 August 2017 at 13:14, Doug Wilson <doug.lkml@...il.com> wrote:
> dev_pm_ops is not supposed to change at runtime. Marking it
> constant.
>
> Signed-off-by: Doug Wilson <doug.wilson@...il.com>

This doesn't apply on my next branch, please re-base it.

Kind regards
Uffe

> ---
>  drivers/mmc/host/omap_hsmmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 04ff3c9..a280c7f 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2322,7 +2322,7 @@ static int omap_hsmmc_runtime_resume(struct device *dev)
>         return 0;
>  }
>
> -static struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
> +static const struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
>         SET_SYSTEM_SLEEP_PM_OPS(omap_hsmmc_suspend, omap_hsmmc_resume)
>         .runtime_suspend = omap_hsmmc_runtime_suspend,
>         .runtime_resume = omap_hsmmc_runtime_resume,
> --
> 2.7.4
>