linux-kernel - Re: scsi: mvsas: replace kfree with scsi_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2017 16:41:33 +0200
From:   Jinpu Wang <jinpu.wang@...fitbricks.com>
To:     Pan Bian <bianpan2016@....com>
Cc:     "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: scsi: mvsas: replace kfree with scsi_host_put

On Tue, Aug 8, 2017 at 2:02 PM, Pan Bian <bianpan2016@....com> wrote:
> The return value of scsi_host_alloc() should be released by
> scsi_host_put(). However, in function mvs_pci_init(), kfree()
> is used. This patch replaces kfree() with scsi_host_put() to avoid
> possible memory leaks.
>
> Signed-off-by: Pan Bian <bianpan2016@....com>
> ---
>  drivers/scsi/mvsas/mv_init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
> index 4e047b5..75bdb38 100644
> --- a/drivers/scsi/mvsas/mv_init.c
> +++ b/drivers/scsi/mvsas/mv_init.c
> @@ -557,14 +557,14 @@ static int mvs_pci_init(struct pci_dev *pdev, const struct pci_device_id *ent)
>         SHOST_TO_SAS_HA(shost) =
>                 kcalloc(1, sizeof(struct sas_ha_struct), GFP_KERNEL);
>         if (!SHOST_TO_SAS_HA(shost)) {
> -               kfree(shost);
> +               scsi_host_put(shost);
>                 rc = -ENOMEM;
>                 goto err_out_regions;
>         }
>
>         rc = mvs_prep_sas_ha_init(shost, chip);
>         if (rc) {
> -               kfree(shost);
> +               scsi_host_put(shost);
>                 rc = -ENOMEM;
>                 goto err_out_regions;
>         }
> --
> 1.9.1
>
>

Looks good to me! Thanks Pan!

Reviewed-by: Jack Wang <jinpu.wang@...fitbricks.com>

-- 
Jack Wang
Linux Kernel Developer

ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin