linux-kernel - Re: scsi: qla2xxx: use dma_mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <543DFC27-27D2-4868-87C1-C941D752E966@cavium.com>
Date:   Tue, 8 Aug 2017 15:24:19 +0000
From:   "Madhani, Himanshu" <Himanshu.Madhani@...ium.com>
To:     Pan Bian <bianpan2016@....com>
CC:     Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@...ium.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: scsi: qla2xxx: use dma_mapping_error to check map errors


> On Aug 8, 2017, at 6:55 AM, Pan Bian <bianpan2016@....com> wrote:
> 
> The return value of dma_map_single() should be checked by
> dma_mapping_error(). However, in function qla26xx_dport_diagnostics(), its
> return value is checked against NULL, which could result in failures.
> 
> Signed-off-by: Pan Bian <bianpan2016@....com>
> ---
> drivers/scsi/qla2xxx/qla_mbx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
> index 7c6d1a4..eafb709 100644
> --- a/drivers/scsi/qla2xxx/qla_mbx.c
> +++ b/drivers/scsi/qla2xxx/qla_mbx.c
> @@ -5817,7 +5817,7 @@ struct cs84xx_mgmt_cmd {
> 
> 	dd_dma = dma_map_single(&vha->hw->pdev->dev,
> 	    dd_buf, size, DMA_FROM_DEVICE);
> -	if (!dd_dma) {
> +	if (dma_mapping_error(&vha->hw->pdev->dev, dd_dma)) {
> 		ql_log(ql_log_warn, vha, 0x1194, "Failed to map dma buffer.\n");
> 		return QLA_MEMORY_ALLOC_FAILED;
> 	}
> -- 
> 1.9.1
> 
> 

Looks Good. Thanks for the patch 

Acked-by: Himanshu Madhani <himanshu.madhani@...ium.com>

Thanks,
- Himanshu