linux-kernel - Re: [PATCH 4.4 17/91] drm: rcar-du: Simplify and fix probe error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2017 09:29:45 -0700
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        thongsyho <thong.ho.px@....renesas.com>,
        Nhan Nguyen <nhan.nguyen.yb@...esas.com>
Subject: Re: [PATCH 4.4 17/91] drm: rcar-du: Simplify and fix probe error
 handling

On Mon, Aug 07, 2017 at 04:17:58PM +0100, Ben Hutchings wrote:
> On Fri, 2017-08-04 at 16:15 -0700, Greg Kroah-Hartman wrote:
> [...]
> > @@ -291,6 +290,15 @@ static int rcar_du_probe(struct platform
> >  	rcdu->dev = &pdev->dev;
> >  	rcdu->info = of_match_device(rcar_du_of_table, rcdu->dev)->data;
> >  
> > +	platform_set_drvdata(pdev, rcdu);
> > +
> > +	/* I/O resources */
> > +	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +	rcdu->mmio = devm_ioremap_resource(&pdev->dev, mem);
> > +	if (IS_ERR(rcdu->mmio))
> > +		ret = PTR_ERR(rcdu->mmio);
> [...]
> 
> Last line above should be:
> 
> 		return PTR_ERR(rcdu->mmio);
> 
> This is an error introduced in the backport, not the upstream commit.

Good catch, thanks for this, I've now fixed it up.

greg k-h