linux-kernel - Re: [PATCH] acpi: apei: fix GHES estatus iteration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2017 17:32:20 +0100
From:   Will Deacon <will.deacon@....com>
To:     Tyler Baicar <tbaicar@...eaurora.org>
Cc:     rjw@...ysocki.net, lenb@...nel.org, james.morse@....com,
        bp@...e.de, shiju.jose@...wei.com, geliangtang@...il.com,
        andriy.shevchenko@...ux.intel.com, tony.luck@...el.com,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        austinwc@...eaurora.org
Subject: Re: [PATCH] acpi: apei: fix GHES estatus iteration

On Thu, Aug 03, 2017 at 03:32:25PM -0600, Tyler Baicar wrote:
> Currently iterating through the GHES estatus blocks does not
> take into account the new generic data v3 structure size. This
> can result in garbage non-standard trace events to be triggered
> since the loop will not properly iterate through the estatus
> blocks and not properly terminate.
> 
> Update the GHES estatus iteration to properly increment through
> the estatus blocks similar to how the CPER estatus printing
> iterates through them.
> 
> Fixes: bbcc2e7b642e ("ras: acpi/apei: cper: add support for generic data v3 structure")
> Signed-off-by: Tyler Baicar <tbaicar@...eaurora.org>
> Tested-by: Austin Christ <austinwc@...eaurora.org>
> ---
>  drivers/acpi/apei/apei-internal.h | 5 -----
>  drivers/acpi/apei/ghes.c          | 8 +++++++-
>  2 files changed, 7 insertions(+), 6 deletions(-)

Whilst much of the initial code here went through the arm64 tree in the
previous merge window, I'm assuming that Boris will take this fix via his
tree (likewise for "[PATCH V2] acpi: apei: clear error status before
acknowledging the error").

Will