linux-kernel - Re: [PATCH] NTB: ntb_tool: Add full multi-port NTB API support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2017 12:26:23 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Serge Semin <fancer.lancer@...il.com>, jdmason@...zu.us,
        dave.jiang@...el.com, Allen.Hubbe@....com,
        Shyam-sundar.S-k@....com, Xiangliang.Yu@....com, gary.hook@....com
Cc:     Sergey.Semin@...latforms.ru, linux-ntb@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NTB: ntb_tool: Add full multi-port NTB API support



On 08/08/17 04:11 AM, Serge Semin wrote:
> +static ssize_t tool_db_event_write(struct file *filep,
> +				   const char __user *ubuf,
> +				   size_t size, loff_t *offp)
> +{
> +	struct tool_ctx *tc = filep->private_data;
> +	u64 val;
> +	int ret;
> +
> +	ret = kstrtou64_from_user(ubuf, size, 0, &val);
> +	if (ret)
> +		return ret;
> +
> +	if (wait_event_interruptible(tc->db_wq, ntb_db_read(tc->ntb) == val))
> +		return -ERESTART;
> +
> +	return size;
> +}

Also, I like the fact that we are adding a db_event feature, however
this really needs to be a separate commit as it's a completely different
feature and not even mentioned in the commit message. There's a few of
these instances.

Logan