linux-kernel - Re: [PATCH 7/9 v2] thermal: bcm2835: constify thermal_zone_of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2017 21:58:07 +0200 (CEST)
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Zhang Rui <rui.zhang@...el.com>,
        Julia Lawall <Julia.Lawall@...6.fr>
Cc:     Scott Branden <sbranden@...adcom.com>, Ray Jui <rjui@...adcom.com>,
        Eric Anholt <eric@...olt.net>, bhumirks@...il.com,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        Florian Fainelli <f.fainelli@...il.com>,
        linux-rpi-kernel@...ts.infradead.org, linux-pm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Eduardo Valentin <edubezval@...il.com>
Subject: Re: [PATCH 7/9 v2] thermal: bcm2835: constify
 thermal_zone_of_device_ops structures


> Julia Lawall <Julia.Lawall@...6.fr> hat am 8. August 2017 um 17:09 geschrieben:
> 
> 
> The thermal_zone_of_device_ops structure is only passed as the fourth
> argument to thermal_zone_of_sensor_register, which is declared as const.
> Thus the thermal_zone_of_device_ops structure itself can be const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Still

Acked-by: Stefan Wahren <stefan.wahren@...e.com>

> 
> ---
> 
> v2: This patch was present in the original series
> 
>  drivers/thermal/broadcom/bcm2835_thermal.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c
> index e6863c8..a4d6a0e 100644
> --- a/drivers/thermal/broadcom/bcm2835_thermal.c
> +++ b/drivers/thermal/broadcom/bcm2835_thermal.c
> @@ -145,7 +145,7 @@ static void bcm2835_thermal_debugfs(struct platform_device *pdev)
>  	debugfs_create_regset32("regset", 0444, data->debugfsdir, regset);
>  }
>  
> -static struct thermal_zone_of_device_ops bcm2835_thermal_ops = {
> +static const struct thermal_zone_of_device_ops bcm2835_thermal_ops = {
>  	.get_temp = bcm2835_thermal_get_temp,
>  };
>  
>