linux-kernel - Re: [PATCH v2 02/20] ath6kl: constify usb_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALupW3BHT80nAYucMN+eNBF4d4b=FR+qXgqy8s+KapKcW5sqoQ@mail.gmail.com>
Date:   Wed, 9 Aug 2017 14:05:45 -0700
From:   Steve deRosier <derosier@...il.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     kvalo@...eaurora.org, petkan@...leusys.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-wireless <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH v2 02/20] ath6kl: constify usb_device_id

On Wed, Aug 9, 2017 at 9:23 AM, Arvind Yadav <arvind.yadav.cs@...il.com> wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
> changes in v2:
>               Re-submitting wireless separately.
>
>  drivers/net/wireless/ath/ath6kl/usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c
> index 9da3594..4defb7a 100644
> --- a/drivers/net/wireless/ath/ath6kl/usb.c
> +++ b/drivers/net/wireless/ath/ath6kl/usb.c
> @@ -1201,7 +1201,7 @@ static int ath6kl_usb_pm_resume(struct usb_interface *interface)
>  #endif
>
>  /* table of devices that work with this driver */
> -static struct usb_device_id ath6kl_usb_ids[] = {
> +static const struct usb_device_id ath6kl_usb_ids[] = {
>         {USB_DEVICE(0x0cf3, 0x9375)},
>         {USB_DEVICE(0x0cf3, 0x9374)},
>         { /* Terminating entry */ },
> --
> 2.7.4
>

Looks good. Also builds and works properly.

Reviewed-by: Steve deRosier <derosier@...il.com>
Tested-by: Steve deRosier <derosier@...il.com>

- Steve