linux-kernel - RE: [PATCH net] net: dsa: ksz: fix skb freeing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Aug 2017 21:43:39 +0000
From:   <Woojung.Huh@...rochip.com>
To:     <vivien.didelot@...oirfairelinux.com>, <netdev@...r.kernel.org>
CC:     <linux-kernel@...r.kernel.org>, <kernel@...oirfairelinux.com>,
        <davem@...emloft.net>, <f.fainelli@...il.com>, <andrew@...n.ch>
Subject: RE: [PATCH net] net: dsa: ksz: fix skb freeing

> The DSA layer frees the original skb when an xmit function returns NULL,
> meaning an error occurred. But if the tagging code copied the original
> skb, it is responsible of freeing the copy if an error occurs.
> 
> The ksz tagging code currently has two issues: if skb_put_padto fails,
> the skb copy is not freed, and the original skb will be freed twice.
> 
> To fix that, move skb_put_padto inside both branches of the skb_tailroom
> condition, before freeing the original skb, and free the copy on error.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Reviewed-by: Woojung Huh <woojung.huh@...rochip.com>