linux-kernel - Re: [PATCH net-next v2 2/2] bpf: Extend check_uarg_tail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170808.181133.1654188772199067010.davem@davemloft.net>
Date:   Tue, 08 Aug 2017 18:11:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mic@...ikod.net
Cc:     linux-kernel@...r.kernel.org, ast@...com, daniel@...earbox.net,
        keescook@...omium.org, kafai@...com, netdev@...r.kernel.org,
        ast@...nel.org
Subject: Re: [PATCH net-next v2 2/2] bpf: Extend check_uarg_tail_zero()
 checks

From: Mickaël Salaün <mic@...ikod.net>
Date: Mon,  7 Aug 2017 20:45:20 +0200

> The function check_uarg_tail_zero() was created from bpf(2) for
> BPF_OBJ_GET_INFO_BY_FD without taking the access_ok() nor the PAGE_SIZE
> checks. Make this checks more generally available while unlikely to be
> triggered, extend the memory range check and add an explanation
> including why the ToCToU should not be a security concern.
> 
> Signed-off-by: Mickaël Salaün <mic@...ikod.net>
> Acked-by: Daniel Borkmann <daniel@...earbox.net>
> Cc: Alexei Starovoitov <ast@...nel.org>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Martin KaFai Lau <kafai@...com>
> Link: https://lkml.kernel.org/r/CAGXu5j+vRGFvJZmjtAcT8Hi8B+Wz0e1b6VKYZHfQP_=DXzC4CQ@mail.gmail.com

Applied.