linux-kernel - Re: [PATCH 0/3] Refactor GHES to better support non-APEI systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d185qejv.fsf@e105922-lin.cambridge.arm.com>
Date:   Wed, 09 Aug 2017 10:24:36 +0100
From:   Punit Agrawal <punit.agrawal@....com>
To:     Borislav Petkov <bp@...e.de>
Cc:     lorenzo.pieralisi@....com, sudeep.holla@....com,
        linux-kernel@...r.kernel.org,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        linux-acpi@...r.kernel.org
Subject: Re: [PATCH 0/3] Refactor GHES to better support non-APEI systems

Punit Agrawal <punit.agrawal@....com> writes:

> Hi,
>
> The small series re-factors the GHES driver initialisation to move
> memory allocation and checks from driver init to device probe. The net
> effect is to improve the situation for systems that do not support
> APEI.
>
> The patches are organised as -
>
> * Unify estatus pool creation and expansion into ghes_estatus_pool_init()
> * Move memory initialisation and firmware first support checks from
>   driver init to device probe
> * Do not set hest_disable if HEST not found
>
> The set of patches initially started out as a single patch[0]. The
> current series is the re-worked approach based on ensuing
> discussion. They patches are based on v4.13-rc3 and have been tested
> on a system that does not support APEI. Further testing on systems
> that support APEI to ensure that the changes do not break expected
> behaviour will be greatly appreciated.

Ping!

Boris, have you had a chance to look at the re-factoring of the GHES init?

>
> Thanks,
> Punit
>
> [0] https://lkml.org/lkml/2017/7/20/430
>
> Punit Agrawal (3):
>   GHES: Expand the estatus pool in ghes_estatus_pool_init()
>   GHES: Move memory initialisation to ghes_probe()
>   ACPI / APEI: HEST: Don't set hest_disable if table not found
>
>  drivers/acpi/apei/ghes.c | 132 ++++++++++++++++++++++++++---------------------
>  drivers/acpi/apei/hest.c |   2 +-
>  2 files changed, 73 insertions(+), 61 deletions(-)