linux-kernel - Re: [PATCH 1/3] staging: most: usb: constify usb_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170809114239.2ac9a210@xps13>
Date:   Wed, 9 Aug 2017 11:42:39 +0200
From:   Christian Gromm <christian.gromm@...rochip.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
CC:     <gregkh@...uxfoundation.org>, <luca@...aceresoli.net>,
        <florian.c.schilhabel@...glemail.com>,
        <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] staging: most: usb: constify usb_device_id

On Tue, 8 Aug 2017 22:53:13 +0530
Arvind Yadav <arvind.yadav.cs@...il.com> wrote:

> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
Acked-by: Christian Gromm <christian.gromm@...rochip.com>
> ---
>  drivers/staging/most/hdm-usb/hdm_usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c
> b/drivers/staging/most/hdm-usb/hdm_usb.c index d0f68cb..a9c3785 100644
> --- a/drivers/staging/most/hdm-usb/hdm_usb.c
> +++ b/drivers/staging/most/hdm-usb/hdm_usb.c
> @@ -832,7 +832,7 @@ static const struct file_operations hdm_usb_fops
> = { /**
>   * usb_device_id - ID table for HCD device probing
>   */
> -static struct usb_device_id usbid[] = {
> +static const struct usb_device_id usbid[] = {
>  	{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_BRDG), },
>  	{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81118), },
>  	{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81119), },



-- 
thanks,
Chris


Christian Gromm
Principal Software Engineer

Microchip Technology Germany II GmbH & Co. KG
Emmy-Noether-Straße 14
76131 Karlsruhe | Germany

Tel: +49 721 62537 466 | Fax: +49 721 62537 119
christian.gromm@...rochip.com | www.microchip.com

Firmensitz: Ismaning
Registergericht: Amtsgericht München, HRA 98692

Persönlich haftende Gesellschafterin: Microchip Technology Germany GmbH
mit Sitz in Ismaning Registergericht: München, HRB 197 653
Geschäftsführer: Mohammed Nawaz Sharif, James Eric Bjornholt, Norbert
Siedhoff

Diese E-Mail kann vertrauliche Informationen enthalten. Sie darf nicht
durch andere als die ursprünglich genannten Adressaten genutzt, kopiert
oder weitergeleitet werden. This e-mail may contain confidential
information and should not be used, copied or disclosed by anyone who
is not the original intended recipient.