linux-kernel - Re: [PATCH] media: i2c: adv748x: Export I2C device table entries as module aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a984305d-6ba2-5b1a-b68a-98a9bcd245df@redhat.com>
Date:   Wed, 9 Aug 2017 12:58:18 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Kieran Bingham <kieran.bingham@...asonboard.com>,
        linux-kernel@...r.kernel.org
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org
Subject: Re: [PATCH] media: i2c: adv748x: Export I2C device table entries as
 module aliases

Hi Kieran,

On 08/09/2017 12:29 PM, Kieran Bingham wrote:
> Hi Javier,
> 
> Thankyou for the patch
>

You are welcome.
 
> On 09/08/17 10:37, Javier Martinez Canillas wrote:
>> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
>> device was registered via OF, and the driver is only exporting the OF ID
>> table entries as module aliases.
>>
>> So if the driver is built as module, autoload won't work since udev/kmod
>> won't be able to match the registered OF device with its driver module.
> 
> Good catch, and perhaps I should have known better :D
> 
> I've only worked on this driver as a built-in so far :-) #BadExcuses
>

A better excuse I think is that after all these years, one would had thought
that the I2C OF modalias issue would had been finally fixed, but not yet :)
 
>> Before this patch:
>>
>> $ modinfo drivers/media/i2c/adv748x/adv748x.ko | grep alias
>> alias:          of:N*T*Cadi,adv7482C*
>> alias:          of:N*T*Cadi,adv7482
>> alias:          of:N*T*Cadi,adv7481C*
>> alias:          of:N*T*Cadi,adv7481
>>
>> After this patch:
>>
>> modinfo drivers/media/i2c/adv748x/adv748x.ko | grep alias
>> alias:          of:N*T*Cadi,adv7482C*
>> alias:          of:N*T*Cadi,adv7482
>> alias:          of:N*T*Cadi,adv7481C*
>> alias:          of:N*T*Cadi,adv7481
>> alias:          i2c:adv7482
>> alias:          i2c:adv7481
>>
>> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
> 
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
> 

Thanks!

Best regards,
-- 
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat