| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Aug 2017 14:22:42 +0200 From: Javier Martinez Canillas <javierm@...hat.com> To: Hans de Goede <hdegoede@...hat.com>, linux-kernel@...r.kernel.org Cc: Lee Jones <lee.jones@...aro.org> Subject: Re: [PATCH 2/2] mfd: intel_soc_pmic_chtwc: Fix module autoload Hello Hans, On 08/09/2017 02:02 PM, Hans de Goede wrote: > Hi, > > On 09-08-17 10:44, Javier Martinez Canillas wrote: >> The driver has a tristate Kconfig symbol so it can be built as a module, >> but it doesn't export the device aliases in the module. So if the driver >> is built as module, autoload won't work since udev/kmod won't be able to >> match the registered ACPI device with its corresponding driver module. >> >> Use the MODULE_DEVICE_TABLE() macro to export the ACPI device as alias. >> >> Before this patch: >> >> $ modinfo drivers/mfd/intel_soc_pmic_chtwc.ko | grep alias >> $ >> >> After this patch >> >> $ modinfo drivers/mfd/intel_soc_pmic_chtwc.ko | grep alias >> alias: acpi*:INT34D3:* >> >> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com> > > As the Kconfig help text mentions this driver should always be > builtin if enabled. But I somehow made a mistake and it became a > tristate in Kconfig instead of a bool. A patch to fix this > (make it a bool) is pending, so this patch is not necessary: > > NACK. > I see, sorry for the noise then. I just looked at the Kconfig symbol but didn't read the Kconfig help text... Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat
Powered by blists - more mailing lists