linux-kernel - Re: [PATCH] drm/bridge: make drm_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Aug 2017 18:06:02 +0530
From:   Archit Taneja <architt@...eaurora.org>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Bhumika Goyal <bhumirks@...il.com>
Cc:     julia.lawall@...6.fr, a.hajda@...sung.com, airlied@...ux.ie,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: make drm_bridge_funcs const



On 08/08/2017 09:33 PM, Laurent Pinchart wrote:
> Hi Bhumika,
> 
> Thank you for the patch.
> 
> On Tuesday 08 Aug 2017 21:24:10 Bhumika Goyal wrote:
>> Make these structures const as they are only stored in the funcs field
>> of drm_bridge structure, which is of type const.
>> Done using Coccinelle.
>>
>> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

queued to drm-misc-next

Thanks,
Archit

> 
>> ---
>>   drivers/gpu/drm/bridge/adv7511/adv7511_drv.c  | 2 +-
>>   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
>> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ee16635..58b4fb2
>> 100644
>> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
>> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
>> @@ -857,7 +857,7 @@ static int adv7511_bridge_attach(struct drm_bridge
>> *bridge) return ret;
>>   }
>>
>> -static struct drm_bridge_funcs adv7511_bridge_funcs = {
>> +static const struct drm_bridge_funcs adv7511_bridge_funcs = {
>>   	.enable = adv7511_bridge_enable,
>>   	.disable = adv7511_bridge_disable,
>>   	.mode_set = adv7511_bridge_mode_set,
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 36f5ccb..63c7a01
>> 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>> @@ -811,7 +811,7 @@ static int dw_mipi_dsi_bridge_attach(struct drm_bridge
>> *bridge) return drm_bridge_attach(bridge->encoder, dsi->panel_bridge,
>> bridge); }
>>
>> -static struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
>> +static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
>>   	.mode_set     = dw_mipi_dsi_bridge_mode_set,
>>   	.enable	      = dw_mipi_dsi_bridge_enable,
>>   	.post_disable = dw_mipi_dsi_bridge_post_disable,
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project