linux-kernel - Re: [PATCH] net: stmmac: Use the right logging function in stmmac_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9067382c-412f-343e-8273-4464366ba0f2@collabora.com>
Date:   Wed, 9 Aug 2017 16:58:24 +0200
From:   Romain Perier <romain.perier@...labora.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: Use the right logging function in
 stmmac_mdio_register

Hi Andrew,


Le 09/08/2017 à 16:56, Andrew Lunn a écrit :
> On Wed, Aug 09, 2017 at 04:40:19PM +0200, Romain Perier wrote:
>> @@ -285,14 +286,14 @@ int stmmac_mdio_register(struct net_device *ndev)
>>  			irq_str = irq_num;
>>  			break;
>>  		}
>> -		netdev_info(ndev, "PHY ID %08x at %d IRQ %s (%s)%s\n",
>> +		dev_info(dev, "PHY ID %08x at %d IRQ %s (%s)%s\n",
>>  			    phydev->phy_id, addr, irq_str, phydev_name(phydev),
>>  			    act ? " active" : "");
> Hi Romain
>
> phy_attached_print() would be better.
>
>      Andrew
Ok, I did not know this function, good to know. I will investigate

Thanks,
Romain