lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Aug 2017 10:26:52 -0700 From: Tony Lindgren <tony@...mide.com> To: "Reizer, Eyal" <eyalr@...com> Cc: Kalle Valo <kvalo@...eaurora.org>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "sebastian.reichel@...labora.co.uk" <sebastian.reichel@...labora.co.uk>, Julian Calaby <julian.calaby@...il.com> Subject: Re: [v6] wlcore: add missing nvs file name info for wilink8 * Reizer, Eyal <eyalr@...com> [170809 00:55]: > --- a/drivers/net/wireless/ti/wlcore/main.c > +++ b/drivers/net/wireless/ti/wlcore/main.c > @@ -6040,6 +6040,21 @@ static int wl1271_register_hw(struct wl1271 *wl) > nic_addr = wl->fuse_nic_addr + 1; > } > > + if (oui_addr == 0xdeadbe && nic_addr == 0xef0000) { > + wl1271_warning("Detected unconfigured mac address in nvs.\n" > + "derive from fuse instead.\n" > + "in case of using a wl12xx device, your " > + "device performance may not be optimized.\n" > + "Please use the calibrator tool to configure " > + "your device.\n" > + "When using a wl18xx device this default nvs " > + "file can be removed from the file system\n"); > + > + oui_addr = wl->fuse_oui_addr; > + /* fuse has the BD_ADDR, the WLAN addresses are the next two */ > + nic_addr = wl->fuse_nic_addr + 1; > + } > + > wl12xx_derive_mac_addresses(wl, oui_addr, nic_addr); I just gave this a quick try on omap3-evm with wl1271, now I get mac address of 00:00:00:00:00:01 :) So looks like at least wl1271 needs to use the random mac address here. Note that we should now have struct wilink_family_data available so maybe that can be used to check if the hardware mac address exists? Regards, Tony
Powered by blists - more mailing lists