linux-kernel - Re: [PATCH] drm/vc4: Fix leak of HDMI EDID

Open Source and information security mailing list archives

Date:   Wed, 9 Aug 2017 19:36:11 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Eric Anholt <eric@...olt.net>
Cc:     dri-devel@...ts.freedesktop.org,
        Stefan Wahren <stefan.wahren@...e.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/vc4: Fix leak of HDMI EDID

On Tue, Aug 08, 2017 at 01:56:05PM -0700, Eric Anholt wrote:
> We don't keep a pointer to it around anywhere, so it's our job to free
> it.
> 
> Cc: Stefan Wahren <stefan.wahren@...e.com>
> Link: https://github.com/anholt/linux/issues/101
> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
> Signed-off-by: Eric Anholt <eric@...olt.net>
Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>
> ---
>  drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index ff09b8e2f9ee..937da8dd65b8 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -288,6 +288,7 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector)
>  	drm_mode_connector_update_edid_property(connector, edid);
>  	ret = drm_add_edid_modes(connector, edid);
>  	drm_edid_to_eld(connector, edid);
> +	kfree(edid);
>  
>  	return ret;
>  }
> -- 
> 2.13.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives