linux-kernel - Re: [PATCH 33/35] wireless: realtek: rtl8192cu: constify usb_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5dca329f-d98c-82f2-1289-0d9d64c39347@lwfinger.net>
Date:   Tue, 8 Aug 2017 23:09:36 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, kvalo@...eaurora.org,
        chaoming_li@...lsil.com.cn
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH 33/35] wireless: realtek: rtl8192cu: constify
 usb_device_id

On 08/08/2017 11:05 AM, Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Thanks,

Larry

>   drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
> index 96c923b..e673bc2 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
> @@ -275,7 +275,7 @@ static struct rtl_hal_cfg rtl92cu_hal_cfg = {
>   #define USB_VENDER_ID_REALTEK		0x0bda
>   
>   /* 2010-10-19 DID_USB_V3.4 */
> -static struct usb_device_id rtl8192c_usb_ids[] = {
> +static const struct usb_device_id rtl8192c_usb_ids[] = {
>   
>   	/*=== Realtek demoboard ===*/
>   	/* Default ID */
>