linux-kernel - Re: [PATCH] kmod: test_kmod: Correctly lock reg_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170809192940.GI27873@wotan.suse.de>
Date:   Wed, 9 Aug 2017 21:29:40 +0200
From:   "Luis R. Rodriguez" <mcgrof@...nel.org>
To:     Daniel Mentz <danielmentz@...gle.com>
Cc:     linux-kernel@...r.kernel.org,
        "Luis R . Rodriguez" <mcgrof@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] kmod: test_kmod: Correctly lock reg_dev_mutex

On Tue, Aug 08, 2017 at 04:27:33PM -0700, Daniel Mentz wrote:
> It appears that, in the preamble of register_test_dev_kmod(),
> mutex_lock() has been confused with mutex_unlock().
> 
> Previously, register_test_dev_kmod() never called mutex_lock() but
> instead, it called mutex_unlock() twice.
> 
> Signed-off-by: Daniel Mentz <danielmentz@...gle.com>
> Cc: Luis R. Rodriguez <mcgrof@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> ---

Thanks Daniel but someone beat you to the fix, I've sent this to Andrew
and he's integrated into his -mm tree. See:

http://lkml.kernel.org/r/20170802211450.27928-5-mcgrof@kernel.org

This series had other fixes:

https://marc.info/?l=linux-kernel&m=150170850624962&w=2

I'll CC you on other kmod / test_kmod changes.

 Luis