linux-kernel - Re: [PATCH v2] selftests: warn if failure is due to lack of executable bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1bf53e2c-e899-2da9-aad7-7b803e22a4fa@kernel.org>
Date:   Wed, 9 Aug 2017 14:47:23 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     "Luis R. Rodriguez" <mcgrof@...nel.org>
Cc:     linux-kselftest@...r.kernel.org, akpm@...ux-foundation.org,
        keescook@...omium.org, pmladek@...e.com, dan.carpenter@...cle.com,
        colin.king@...onical.com, dcb314@...mail.com,
        linux-kernel@...r.kernel.org,
        Michael Ellerman <mpe@...erman.id.au>,
        Shuah Khan <shuah@...nel.org>,
        shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v2] selftests: warn if failure is due to lack of
 executable bit

On 08/08/2017 11:50 AM, Luis R. Rodriguez wrote:
> On Thu, Aug 03, 2017 at 01:24:36PM -0700, Luis R. Rodriguez wrote:
>> Executing selftests is fragile as if someone forgot to set a secript
>> as executable the test will fail, and you won't know for sure if the
>> failure was caused by the lack of proper permissions or something else.
>>
>> Setting scripts as executable is required, this also enable folks to
>> execute selftests as independent units.
>>
>> Signed-off-by: Luis R. Rodriguez <mcgrof@...nel.org>
>> ---
>>  tools/testing/selftests/lib.mk | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
>> index 959273c3a52e..e71f8e4633b1 100644
>> --- a/tools/testing/selftests/lib.mk
>> +++ b/tools/testing/selftests/lib.mk
>> @@ -14,7 +14,12 @@ all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES)
>>  define RUN_TESTS
>>  	@for TEST in $(TEST_GEN_PROGS) $(TEST_PROGS); do \
>>  		BASENAME_TEST=`basename $$TEST`;	\
>> -		cd `dirname $$TEST`; (./$$BASENAME_TEST && echo "selftests: $$BASENAME_TEST [PASS]") || echo "selftests:  $$BASENAME_TEST [FAIL]"; cd -;\
>> +		if [ ! -x $$BASENAME_TEST ]; then	\
>> +			echo "selftests: Warning: file $$BASENAME_TEST is not executable, correct this.";\
>> +			echo "selftests: $$BASENAME_TEST [FAIL]"; \
>> +		else					\
>> +			cd `dirname $$TEST`; (./$$BASENAME_TEST && echo "selftests: $$BASENAME_TEST [PASS]") || echo "selftests:  $$BASENAME_TEST [FAIL]"; cd -;\
>> +		fi;					\
>>  	done;
>>  endef
>>  
> 
> *poke*
> 
>   Luis
> 
> 

Applied to linux-kselftest next for 4.14-rc1.

thanks,
-- Shuah