linux-kernel - Re: [PATCH RESEND] mailbox: pcc: Drop uninformative output during boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1791419.fgGbrxCany@aspire.rjw.lan>
Date:   Fri, 11 Aug 2017 01:08:18 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Punit Agrawal <punit.agrawal@....com>
Cc:     rafael.j.wysocki@...el.com, linux-acpi@...r.kernel.org,
        Alexey Klimov <alexey.klimov@....com>,
        linux-kernel@...r.kernel.org, lorenzo.pieralisi@....com,
        sudeep.holla@....com, Jassi Brar <jassisinghbrar@...il.com>
Subject: Re: [PATCH RESEND] mailbox: pcc: Drop uninformative output during boot

On Tuesday, August 1, 2017 2:43:57 PM CEST Punit Agrawal wrote:
> When booting on an ACPI enabled system that does not provide the
> Platform Communications Channel Table (PCCT), the pcc mailbox driver
> prints -
> 
> [    0.484261] PCCT header not found.
> 
> during probe before returning -ENODEV.
> 
> This message clutters the bootlog and doesn't provide any useful
> information. Drop this message.
> 
> Signed-off-by: Punit Agrawal <punit.agrawal@....com>
> Cc: Jassi Brar <jassisinghbrar@...il.com>
> Acked-by: Alexey Klimov <alexey.klimov@....com>
> ---
> 
> Hi Rafael,
> 
> Re-sending the patch with linux-acpi on cc and tags applied as
> requested. If there are no objections please consider merging.
> 
> Thanks,
> Punit
> 
>  drivers/mailbox/pcc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
> index ac91fd0d62c6..3d83cdc11ab5 100644
> --- a/drivers/mailbox/pcc.c
> +++ b/drivers/mailbox/pcc.c
> @@ -457,10 +457,8 @@ static int __init acpi_pcc_probe(void)
>  	/* Search for PCCT */
>  	status = acpi_get_table(ACPI_SIG_PCCT, 0, &pcct_tbl);
>  
> -	if (ACPI_FAILURE(status) || !pcct_tbl) {
> -		pr_warn("PCCT header not found.\n");
> +	if (ACPI_FAILURE(status) || !pcct_tbl)
>  		return -ENODEV;
> -	}
>  
>  	count = acpi_table_parse_entries(ACPI_SIG_PCCT,
>  			sizeof(struct acpi_table_pcct),
> 

Applied, thanks!