[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <cover.1502408518.git.mchehab@s-opensource.com>
Date: Thu, 10 Aug 2017 20:45:10 -0300
From: Mauro Carvalho Chehab <mchehab@...pensource.com>
To: Linux Doc Mailing List <linux-doc@...r.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@...pensource.com>,
Mauro Carvalho Chehab <mchehab@...radead.org>,
linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>,
Hans Verkuil <hverkuil@...all.nl>,
Stanimir Varbanov <stanimir.varbanov@...aro.org>,
Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Hans Verkuil <hans.verkuil@...co.com>,
Kieran Bingham <kieran@...uared.org.uk>,
Tomasz Figa <tfiga@...omium.org>
Subject: [PATCH 0/3] v4l2-compat-ioctl32.c: better detect pointer controls
In the past, only string controls were pointers. That changed when compounded
types got added, but the compat32 code was not updated.
We could just add those controls there, but maintaining it is flaw, as we
often forget about the compat code. So, instead, rely on the control type,
as this is always updated when new controls are added.
As both v4l2-ctrl and compat32 code are at videodev.ko module, we can
move the ctrl_is_pointer() helper function to v4l2-ctrl.c.
Mauro Carvalho Chehab (3):
media: v4l2-ctrls.h: better document the arguments for v4l2_ctrl_fill
media: v4l2-ctrls: prepare the function to be used by compat32 code
media: compat32: reimplement ctrl_is_pointer()
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 18 +---------
drivers/media/v4l2-core/v4l2-ctrls.c | 49 +++++++++++++++++++++++++--
include/media/v4l2-ctrls.h | 28 ++++++++++-----
3 files changed, 67 insertions(+), 28 deletions(-)
--
2.13.3
Powered by blists - more mailing lists