linux-kernel - Re: [PATCH 1/2] cpufreq: schedutil: Don't restrict kthread to related

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEU1=PmXWPdpATvSaj0d8ZrhTtWq6hznXGQc3ipO7AGXE_Pjiw@mail.gmail.com>
Date:   Thu, 10 Aug 2017 12:28:30 +0530
From:   Pavan Kondeti <pkondeti@...eaurora.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Rafael Wysocki <rjw@...ysocki.net>, Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-pm@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Juri Lelli <Juri.Lelli@....com>,
        Joel Fernandes <joelaf@...gle.com>,
        Pavan Kondeti <pkondeti@...eaurora.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] cpufreq: schedutil: Don't restrict kthread to
 related_cpus unnecessarily

On Thu, Aug 10, 2017 at 9:50 AM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
> Utilization update callbacks are now processed remotely, even on the
> CPUs that don't share cpufreq policy with the target CPU (if
> dvfs_possible_from_any_cpu flag is set).
>
> But in non-fast switch paths, the frequency is changed only from one of
> policy->related_cpus. This happens because the kthread which does the
> actual update is bound to a subset of CPUs (i.e. related_cpus).
>
> Allow frequency to be remotely updated as well (i.e. call
> __cpufreq_driver_target()) if dvfs_possible_from_any_cpu flag is set.
>
> Reported-by: Pavan Kondeti <pkondeti@...eaurora.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
>  kernel/sched/cpufreq_schedutil.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> index 2e74c49776be..504d0752f8f2 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -487,7 +487,11 @@ static int sugov_kthread_create(struct sugov_policy *sg_policy)
>         }
>
>         sg_policy->thread = thread;
> -       kthread_bind_mask(thread, policy->related_cpus);
> +
> +       /* Kthread is bound to all CPUs by default */
> +       if (!policy->dvfs_possible_from_any_cpu)
> +               kthread_bind_mask(thread, policy->related_cpus);
> +

LGTM. Your other patch in this series is also nice. Thanks for doing it.

Thanks,
Pavan

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project