linux-kernel - Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1502361454.10792.5.camel@pengutronix.de>
Date:   Thu, 10 Aug 2017 12:37:34 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Katsuhiro Suzuki <suzuki.katsuhiro@...ionext.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     Masami Hiramatsu <masami.hiramatsu@...aro.org>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

Hi Katsuhiro,

On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:
> Add a reset line for analog signal amplifier core (ADAMV) on
> UniPhier LD11/LD20 SoCs.
> 
> > Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@...ionext.com>
> ---
>  drivers/reset/reset-uniphier.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
> index f60c137c17cb..cda4a78a58e2 100644
> --- a/drivers/reset/reset-uniphier.c
> +++ b/drivers/reset/reset-uniphier.c
> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data uniphier_pro4_peri_reset_data[] = {
> >  	UNIPHIER_RESET_END,
>  };
>  
> +/* Analog signal amplifiers reset data */
> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {
> > +	UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
> > +	UNIPHIER_RESET_END,
> +};
> +
>  /* core implementaton */
>  struct uniphier_reset_priv {
> >  	struct reset_controller_dev rcdev;
> @@ -415,6 +421,15 @@ static const struct of_device_id uniphier_reset_match[] = {
> >  		.compatible = "socionext,uniphier-ld20-peri-reset",
> >  		.data = uniphier_pro4_peri_reset_data,
> >  	},
> > +	/* Analog signal amplifiers reset */
> > +	{
> > +		.compatible = "socionext,uniphier-ld11-adamv-reset",
> > +		.data = uniphier_ld11_adamv_reset_data,
> > +	},
> > +	{
> > +		.compatible = "socionext,uniphier-ld20-adamv-reset",
> > +		.data = uniphier_ld11_adamv_reset_data,
> > +	},
> >  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, uniphier_reset_match);

Please add a patch to describe the new compatible values in
Documentation/devicetree/bindings/reset/uniphier-reset.txt.

regards
Philipp