linux-kernel - Re: [PATCH 1/1] f2fs: merge equivalent flags F2FS_GET_BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <98fd4a5d-bec8-af99-14a0-93a006437b8f@huawei.com>
Date:   Thu, 10 Aug 2017 18:45:26 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     sunqiuyang <sunqiuyang@...wei.com>, <linux-kernel@...r.kernel.org>,
        <linux-fsdevel@...r.kernel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>
Subject: Re: [PATCH 1/1] f2fs: merge equivalent flags
 F2FS_GET_BLOCK_[READ|DIO]

On 2017/8/9 17:27, sunqiuyang wrote:
> From: Qiuyang Sun <sunqiuyang@...wei.com>
> 
> Currently, the two flags F2FS_GET_BLOCK_[READ|DIO] are totally equivalent
> and can be used interchangably in all scenarios they are involved in. 
> Neither of the flags is referenced in f2fs_map_blocks(), making them both 
> the default case. To remove the ambiguity, this patch merges both flags
> into F2FS_GET_BLOCK_DEFAULT, and introduces an enum for all distinct flags.
> 
> Signed-off-by: Qiuyang Sun <sunqiuyang@...wei.com>

Reviewed-by: Chao Yu <yuchao0@...wei.com>